Skip to content

added node pool maintenance policy#17190

Draft
yliaog wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
yliaog:np_maintenance_policy
Draft

added node pool maintenance policy#17190
yliaog wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
yliaog:np_maintenance_policy

Conversation

@yliaog
Copy link
Copy Markdown
Contributor

@yliaog yliaog commented Apr 17, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `maintenance_policy` field to `google_container_node_pool` resource

@yliaog yliaog marked this pull request as draft April 17, 2026 23:46
@github-actions github-actions bot requested a review from SirGitsalot April 17, 2026 23:47
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 215 insertions(+), 144 deletions(-))
google-beta provider: Diff ( 1 file changed, 226 insertions(+), 165 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContainerNodePool_withMaintenancePolicy

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 273 insertions(+), 144 deletions(-))
google-beta provider: Diff ( 2 files changed, 284 insertions(+), 165 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContainerNodePool_withMaintenancePolicy

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@yliaog yliaog force-pushed the np_maintenance_policy branch from 73861ff to c096347 Compare April 18, 2026 00:24
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 133 insertions(+))
google-beta provider: Diff ( 2 files changed, 133 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContainerNodePool_withMaintenancePolicy

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@yliaog yliaog force-pushed the np_maintenance_policy branch from c096347 to cd7be8b Compare April 18, 2026 23:37
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 140 insertions(+))
google-beta provider: Diff ( 4 files changed, 140 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccContainerNodePool_withMaintenancePolicy

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants